Fix multiple issues when building on Windows/Linux/Darwin 2019 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly quote CFLAGS to avoid build failure if more than one flag is passed (make CFLAGS="-m32 -O3" for instance), see: patthoyts#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to build Tclkit recently with Tcl/Tk 8.6.9:
To be specific, it's tcl8.6.9-src.tar.gz and tk8.6.9.1-src.tar.gz.
There's a lot of things should change to make it work.
And now it works, here's the code.
I agree with @l3iggs about tags or release here, maybe we should get one.
And this PR is included already.